search

dns-violations / dnsflagday

DNS flag day
https://dnsflagday.net/
147 stars 40 forks source link

proposed quick fix to checker.yaml #57

Closed vrisk closed 5 years ago

vrisk commented 5 years ago

This is a crappy way to do this, but I don't know how to fix the issue that the layout isn't displaying the field labelled "title" which explains you should enter a zone name, so I just prefixed the prompt for the zone name with the text in the 'title' field. I won't be offended if you ignore this, because I am not sure it will help users who are confused anyway, but at least I took a stab at it. I did change the English version slightly, but did not feel qualified to muck with the other languages. Maybe it would be better to give some example zone names (that pass the test)??

jelu commented 5 years ago

Title is what displayed when you hover the input box, naming of the variables comes from original code. This fix is not really good since the text before the input box is bloated. Donno if @pspacek revamp will fix this perhaps?

jelu commented 5 years ago

You could change legend or we can add another text variable and put it under legend and above title and input box?

vrisk commented 5 years ago

Nah, I am going to cancel the pull request and check out the new wording submitted overnight. That is much better anyway and a much bigger overhaul.