search

dnschneid / crouton

Chromium OS Universal Chroot Environment
https://goo.gl/fd3zc?si=1
BSD 3-Clause "New" or "Revised" License
8.57k stars 1.24k forks source link

Request: Provide a way to set the XMETHOD before entering a chroot #1387

Closed DennisLfromGA closed 9 years ago

DennisLfromGA commented 9 years ago

This goes along with Issue https://github.com/dnschneid/crouton/issues/1274, now that there is a working implementation of setting the XMETHOD.

In the above thread with @dnschneid, we discussed -

...add an x11 method parameter to enter-chroot that would set the environment variable...

Since there have been numerous requests to switch between 'xiwi' and 'xorg/xephyr' or even switch back from 'xiwi' to 'xorg/xephyr' permanently, I thought it might be of value to have a method to switch between these XMETHODs on a temporary basis at least.

I've got a working patch-3 that employs a '-X' option in enter-chroot to override the the auto-detected XMETHOD for that session. Also, maybe later we could provide a way to set the XMETHOD permanently via '-XX' or something...

( @dnschneid & @drinkcat - I'd like to get your input and get it cleaned up a little before I submit a pr if this looks like something feasible and worthy. :)

dnschneid commented 9 years ago

Looks like @aetsher created a PR for you in #1388. I'll add feedback there. If we were to add a permanent modification as an alternative to updating the chroot, it should be in edit-chroot.

DennisLfromGA commented 9 years ago

Yup, I saw that, I thought that I would have to submit the PR, shows you how little I understand github.

I'd like to get your input and get it cleaned up a little before I submit a pr if this looks like something feasible and worthy. :)

Maybe it's for the best though, hopefully it won't require too much work to provide a good a solution. It makes perfect sense to put the permanent mod. in edit-chroot, I hadn't thought of that. I might work on something there too.

dnschneid commented 9 years ago

PR merged. -X ftw

DennisLfromGA commented 9 years ago

Yay, thanx. I've added XMETHOD to the Autostart config (https://gist.github.com/DennisLfromGA/6443733) too.

On Fri, Feb 6, 2015 at 7:18 PM, David Schneider notifications@github.com wrote:

PR merged. -X ftw

— Reply to this email directly or view it on GitHub https://github.com/dnschneid/crouton/issues/1387#issuecomment-73337831.

DennyL@GMail