dnsev / 4cs

Media player userscript, steganographic embedding
https://dnsev.github.io/4cs
15 stars 3 forks source link

player not working #31

Closed ggeecckkoo closed 11 years ago

ggeecckkoo commented 11 years ago

i'm using chrome with tampermonkey, have no other scripts besides this one and sound uploader when i'm clicking on embedded youtube links they just opens in another tab and refuses to play in the media player. sound files works perfectly though. have tried resetting the settings, refreshing the page and re-installing the script.

dnsev commented 11 years ago

Did you try:

ggeecckkoo commented 11 years ago

yes

dnsev commented 11 years ago

Well first of all, the sound uploader extension isn't necessary anymore; 4cs has one included in it.

Second, I'd recommend checking the error console (in the tab running the extension) after you've clicked a link and see if anything pops up.

Also make sure that under your [Settings] -> Link Replacement, "Media URLs ..." options are enabled.

ggeecckkoo commented 11 years ago

found the solution, had to go in chrome://flags and enable experimental javascript and relaunch the browser in order for 4cs to work

Edit: It appears that this only fixed the issue with the script opening the embedded youtube video into tab, but the video won't load into the player. I checked the console and saw "Uncaught Error: NotFoundError: DOM Exception 8" with "DOMException {message: "NotFoundError: DOM Exception 8", name: "NotFoundError", code: 8, stack: "Error: An attempt was made to reference a Node in …pobfkfo/content.js:49:48))), :8105:20)", INDEX_SIZE_ERR: 1…}" above it So I digged a little further and found out that the error was related to this line: "window._unsafe.tag.parentNode.removeChild(window._unsafe.tag);". 20 -v- - good bossfights 22 -v- - good bossfight

i do not know what this means

dnsev commented 11 years ago

found the solution, had to go in chrome://flags and enable experimental javascript and relaunch the browser in order for 4cs to work That is really odd, I -- actually I found out why that was happening, and that was a "bug" in my script.

The bad news is this doesn't look fixable since chrome apparently did something awful to userscripts security-wise not so long back. Trying to code and communicate with embedded YT/Vimeo/Soundcloud content has always been a pain in Chrome, and has mainly worked by a Javascript hack.

Trying to fix this for Chrome looks like it would involve having 2 window communication buffers which isn't something that looks very fun to try and do; so I can't promise I'll fix this soon (if at all) for 4cs.


For now, the easiest thing I can suggest is either:

ggeecckkoo commented 11 years ago

ok, none of those worked but i have changed my browser to firefox and everything is working perfectly, for the moment.