search

dnsev / 4cs

Media player userscript, steganographic embedding
https://dnsev.github.io/4cs
15 stars 3 forks source link

Player won't recognize youtube links when the ?v=XXXXXXXXX has _ or - in it. #50

Closed Never22 closed 10 years ago

Never22 commented 10 years ago

Title, I recently noticed in a post that only two links weren't working with the media player and it turned out they were the only ones with a _ and a - in them. So basically any youtube link with special characters is fucked.

Edit: I really should have tested it before I posted. That doesn't seem to be the issue. So fuck me backwards. Just ignore this.

dnsev commented 10 years ago

Related comment I guess, but I think some of the new 4chan-x scripts have been changing the way the index pages work, and I've seen many times 4cs simply not activate on an index page, and sometimes it will.

I haven't looked much into the cause yet since it's so sporadic, but that could potentially be the cause.

(I've done a good job of ignoring this I feel.)

Never22 commented 10 years ago

Actually I think I've found the issue. I use ihavenoface's fork of 4chan X, and in it's settings under "Linkification" it has the option "Link Titles: Fetch and replace links with titles of embeddable content.", as soon as I disabled that everything has worked perfectly so far. I have an issue with this though, the underline on the media player's version of "Link Titles" bleeds into the text and it's kind of annoying. Could you change it? divide

dnsev commented 10 years ago

Fixed the underline issue in 5.0.0.1.1/cl

Honestly I'm surprised nobody has pointed that out by now. I completely forgot because my links don't have underlines on.