search

dnsev / 4cs

Media player userscript, steganographic embedding
https://dnsev.github.io/4cs
15 stars 3 forks source link

Doesn't seem to recognize youtu.be links if they don't have the http:// before it #53

Closed Never22 closed 10 years ago

Never22 commented 10 years ago

So I was strolling along /vg/ one day when I stumbled on this- capture 4chan X gets the embed right but the movie player doesn't seem to recognize it at all. I messed with things in my settings to see if it was me but I couldn't find anything so I'm posting here.

dnsev commented 10 years ago

Yeah, it seems 4cs doesn't check for links that look like something.xx. Mainly because I think that historically, 4chan-x didn't parse those links either. Also I notice a lot of false positives when it does when people forget a space after the end of a sentence.

I can get it updated to hijack links created by 4chan-x and convert them into video links, but I probably won't be making it detect something.xx as links, because of the number of regex rules that would need to be written, and how it would introduce the problem above.

Should be updated in 5.0.2/cl