dnsimple / dns_erlang

Erlang DNS library.
Apache License 2.0
95 stars 25 forks source link

crypto:sha/1 deprecated in factor of crypto:hash/2 #15

Closed coreyhaines closed 6 years ago

coreyhaines commented 6 years ago

closes #14

At some point (I believe it was OTP20), crypto:sha/1 was removed in favor of crypto:hash/2. This was causing a dnssec test to fail because we were relying on crypto:sha/1 in the case of using DNSSEC_NSEC3_ALG_SHA1 when creating the NSEC3 hash function.

This appears to be a duplicate of #11's replacement https://github.com/dnsimple/dns_erlang/pull/11/files#diff-c719f7209c32881c61604752ee906516L171 that was closed and implemented directly in master. But this was missed.