Add support for key-data interface creating delegation signer records

dnsimple / dnsimple-node

The DNSimple API client for Node.js.

https://developer.dnsimple.com/

MIT License

47 stars 18 forks source link

Add support for key-data interface creating delegation signer records #110

Closed OleMchls closed 3 years ago

OleMchls commented 3 years ago

This PR:

Updates the fixtures from dnsimple-developer repo to reflect the latest changes to our DNSSEC-related APIs.

I was able to verify the changes by enabling DNSSEC on one of our testing .BE domains.

OleMchls commented 3 years ago

👍 This looks good to me.

I noticed that we have some additional assertions for TLDs in our PHP library that may be worth adding here: https://github.com/dnsimple/dnsimple-php/pull/29/files#diff-9dc633697db3cfcd0f408f8e35c138d7b6f480f43ed3d8e4fd2891c44ac1731aR74-R77

Added in 4907d5e