search

dnsimple / dnsimple-node

The DNSimple API client for Node.js.
https://developer.dnsimple.com/
MIT License
47 stars 19 forks source link

Documentation: breaking changes between versions 4.x and 5.x? #121

Closed aral closed 2 years ago

aral commented 2 years ago

Hi there,

I can’t see any mention of breaking changes from 4.x to 5.x even though it’s a major semver upgrade.

Were there any that haven’t been documented in the changelog or should we treat this as a minor semver upgrade?

Thanks!

san983 commented 2 years ago

Hi there,

I can’t see any mention of breaking changes from 4.x to 5.x even though it’s a major semver upgrade.

Were there any that haven’t been documented in the changelog or should we treat this as a minor semver upgrade?

Thanks!

Hi there @aral!

Actually there are 2 breaking changes that were documented in the changelog

CHANGED: Deprecates support for NodeJS v10 (EOL) CHANGED: Deprecates registrar.getDomainPremiumPrice in favour of registrar.getDomainPrices

Please let us know if there is any other doubt!

aral commented 2 years ago

Ah, ok, I wasn’t sure if deprecate meant warning or error; I assume error, then :) Thanks!