dnsimple / dnsimple-node

The DNSimple API client for Node.js.
https://developer.dnsimple.com/
MIT License
48 stars 19 forks source link

Implement getDomainRegistration and getDomainRenewal APIs #169

Closed ghost closed 1 year ago

ghost commented 1 year ago

Implement the getDomainRegistration and getDomainRenewal API methods.

We're starting to test the library in a new way, by testing the network request only, as our library does not handle responses for each method specifically, so current response tests do not test actual code. For example, we generically deserialise all responses into an untyped object and do not actually map and validate fields, which is standard JS. Currently, we also don't sync the fixtures, so our tests don't reflect the actual current API schema.

We will test this by using sinon to mock the client request function to ensure that the network requests exactly match. Our plan is to slowly migrate existing tests towards this model.