Why erldns_server_sup is not under supervision tree?

[T0ha]

erldns_server_sup for some reason is started not from supervision tree. This makes erldns not crash, but run defunctional when servers crash for some reason. Can I fix it or there are some reason I've missed?

[aeden]

Are you seeing specific crashes? If so, can you provide the crash details?

It might make sense to put it under this supervisor under a supervision tree as well, however there is a caveat: erldns_server_sup must be started only when the start_servers event is received. This is necessary to ensure all zones are loaded in the cache before answering requests.

[T0ha]

What about supervisor:start_child(erldns_sup,

{id => erldns_sup,

                           start => { erldns_server_sup, start_link, [] },
                           restart => permanent,
                           shutdown => 5000,
                           type => supervisor,
                           modules => [erldns_sup]}),

???

[aeden]

If you would like to submit a PR I can test it out in the DNSimple environment and make sure it does not negatively impact operations.

[T0ha]

I'll do it in a while

[aeden]

This will be fixed as part of the 2.x.x release.