erldns_zone_cache:get_authority() spec mismatch

dnsimple / erldns

DNS server, in Erlang.

MIT License

402 stars 98 forks source link

erldns_zone_cache:get_authority() spec mismatch #63

Closed fdbeirao closed 7 years ago

fdbeirao commented 7 years ago

erldns_zone_cache.erl:131 returns authority_not_found, instead of no_authority

aeden commented 7 years ago

Thanks for the PR!

fdbeirao commented 7 years ago

No prob. I am trying to study a real-life erlang application, as part of my erlang learning journey. I am going through the code and just studying it, without getting much in depth of the actual DNS protocol. I have only seen 1% of the code so far, but it looks exactly like what I was expecting: clean & organized.

aeden commented 7 years ago

It still has its dark corners. 😉