search

dnsimple / terraform-provider-dnsimple

Terraform DNSimple provider.
https://www.terraform.io/docs/providers/dnsimple/
Mozilla Public License 2.0
22 stars 20 forks source link

[PROPOSAL] Switch to Go Modules #13

Closed appilon closed 5 years ago

appilon commented 5 years ago

As part of the preparation for Terraform v0.12, we would like to migrate all providers to use Go Modules. We plan to continue checking dependencies into vendor/ to remain compatible with existing tooling/CI for a period of time, however go modules will be used for management. Go Modules is the official solution for the go programming language, we understand some providers might not want this change yet, however we encourage providers to begin looking towards the switch as this is how we will be managing all Go projects in the future. Would maintainers please react with :+1: for support, or :-1: if you wish to have this provider omitted from the first wave of pull requests. If your provider is in support, we would ask that you avoid merging any pull requests that mutate the dependencies while the Go Modules PR is open (in fact a total codefreeze would be even more helpful), otherwise we will need to close that PR and re-run go mod init. Once merged, dependencies can be added or updated as follows:

$ GO111MODULE=on go get github.com/some/module@master
$ GO111MODULE=on go mod tidy
$ GO111MODULE=on go mod vendor

GO111MODULE=on might be unnecessary depending on your environment, this example will fetch a module @ master and record it in your project's go.mod and go.sum files. It's a good idea to tidy up afterward and then copy the dependencies into vendor/. To remove dependencies from your project, simply remove all usage from your codebase and run:

$ GO111MODULE=on go mod tidy
$ GO111MODULE=on go mod vendor

Thank you sincerely for all your time, contributions, and cooperation!

martinisoft commented 5 years ago

I'm totally down to help make this change and can put up a PR for it. I've been converting all my projects to Go modules myself. Thank you for the informative issue posting ❤️

martinisoft commented 5 years ago

Also it looks like I'll need to be added as a collaborator to this repo. I'm sure @weppos will chime in with a 👍 on this change too.

weppos commented 5 years ago

@martinisoft @appilon works for me. 👍

@appilon do you know who we can ask to add @martinisoft as collaborator to this repo?

cgriggs01 commented 5 years ago

Hi @weppos

Thank you for approving the request, I can help get 'martinisoft' added as a maintainer.

@martinisoft I'll reach out via email with HashiCorp Community Guidelines.

Thank you both for working on this provider!