dnsimple / terraform-provider-dnsimple

Terraform DNSimple provider.
https://www.terraform.io/docs/providers/dnsimple/
Mozilla Public License 2.0
21 stars 20 forks source link

Allow creating LetsEncrypt cert with multiple names #92

Closed pswaminathan closed 1 year ago

pswaminathan commented 1 year ago

Creating a LetsEncrypt cert covering multiple names is supported by the website, and it would be nice if the terraform provider supported it as well. Currently the name argument only takes a single subdomain.

Terraform Version

v1.3.7

Affected Resource(s)

Please list the resources as a list, for example:

Terraform Configuration Files

resource "dnsimple_lets_encrypt_certificate" "combined_tls_certificate" {
  domain_id  = var.dnsimple_domain_id
  name       = "www,someothersubdomain"
  auto_renew = true
}

Expected Behavior

Single certificate covering both www and someothersubdomain is created.

Actual Behavior

Validation error

DXTimer commented 1 year ago

Hi @pswaminathan thank you for taking the time to make the request, and bringing this to our attention. I am glad to let you know that we fully agree and plan to have the attribute available for configuration in the coming weeks.

pswaminathan commented 1 year ago

Great, thank you!

ghost commented 1 year ago

Great news @pswaminathan, we've released version 1.1.0 which has added support for alternate names on the dnsimple_lets_encrypt_certificate resource.