search

dnsl48 / fraction

[Rust] Lossless fractions and decimals; drop-in float replacement
Apache License 2.0
83 stars 25 forks source link

Completing implemention of `identities` module from `num_traits` #104

Closed saona-raimundo closed 5 months ago

saona-raimundo commented 7 months ago

Thanks for the work!

I wanted to point out that there are two more traits to implement from the num_traits. num_traits::identities::ConstOne and num_traits::identities::ConstZero

I would do a PR if you accept implementing these. They should be the same as the respective One and Zero traits implementation.

dnsl48 commented 6 months ago

Hi @saona-raimundo, Sure, PRs are welcome. Otherwise, we may add that into the next release.

saona-raimundo commented 6 months ago

I opened an issue in the num crate as its dependencies should be updated to export these traits directly. This way we do not add a direct dependency to num-traits in fraction.

dnsl48 commented 5 months ago

Hi @saona-raimundo, Thank you for the contribution! It is released as a part of 0.15.2.