dnsl48 / fraction

[Rust] Lossless fractions and decimals; drop-in float replacement
Apache License 2.0
83 stars 25 forks source link

added Ord trait to GenericFraction #74

Closed DrAlta closed 1 year ago

DrAlta commented 1 year ago

I made it so the NaN is less than everything else.

I needed this, so I can use fractions as the key to a BTreeMap.

dnsl48 commented 1 year ago

Yep, looks good, thank you for the contribution! The patch itself is looking alright, but there are some formatting issues, a couple of semantic things that clippy has picked up and perhaps a couple of tests are worth writing. We should be able to do this after this is merged, no worries :+1: