search

dnvriend / akka-persistence-inmemory

Akka-persistence-inmemory is a plugin for akka-persistence that stores journal and snapshot messages memory, which is very useful when testing persistent actors, persistent FSM and akka cluster
Apache License 2.0
134 stars 41 forks source link

Dropping support for Akka 2.4 for 2.5 #57

Open dnvriend opened 6 years ago

dnvriend commented 6 years ago

Akka 2.4.20 is now 1 year old, I am dropping support for it. The 2.5.0.0 branch will be renamed to master and the codebase will be refactored to support 2.5.0. The current master will be renamed to 2.4.20.

cosmir17 commented 5 years ago

Hi Dennis( @dnvriend ),

I would like to ask you about versioning for Akka dependencies. I see that you are currently providing support for Akka version 2.5.15

Does it mean Akka version 2.5.20 is not currently supported? I am happy to use the older Akka version(2.5.15) if it's not the case.

Thank you, Sean

P.S. This might be already discussed. Would it be ok to have 2.5.15.1 in the Maven repository, please? Currently, versions up to 2.5.1.1 is listed. https://mvnrepository.com/artifact/com.github.dnvriend/akka-persistence-inmemory I can use 'Bintray' repository but I prefer to use the Maven repository.

BeatSager commented 5 years ago

We use it currently an own build 2.4.20 version with Akka 2.5.19 and it works fine. The patch we use is only this https://github.com/dnvriend/akka-persistence-inmemory/pull/59 .

cosmir17 commented 5 years ago

I have experimented with the (dnvriend)2.5.15.1 version. I got the following log message. For the (dvriend) 2.5.1.1 version, you can replace 2.5.15 to 2.5.1 in the same message.

akka.util.ManifestInfo - Detected possible incompatible versions on the classpath. Please note that a given Akka version MUST be the same across all modules of Akka that you are using, e.g. if you use [2.5.20] all other modules that are released together MUST be of the same version. Make sure you're using a compatible set of libraries. Possibly conflicting versions [2.5.20, 2.5.15] in libraries [akka-persistence:2.5.20, akka-protobuf:2.5.20, akka-persistence-query:2.5.15, akka-actor:2.5.20, akka-slf4j:2.5.20, akka-stream:2.5.15]

@BeatSager Did you have a similar log when you built with Akka 2.5.19? Should I ignore this warning for Akka 2.5.20 version?

cosmir17 commented 5 years ago

@BeatSager in the end, I used akka 2.5.15. The warning message disappeared.

BeatSager commented 5 years ago

Would be great when the 2.5.0.0 could be rebased on the current master so that for example the #59 is available in 2.5.