dnvriend / akka-serialization-test

Study on akka-serialization using ProtoBuf, Kryo and Avro
Apache License 2.0
31 stars 7 forks source link

Avro evolution 2 #5

Closed giampaolotrapasso closed 8 years ago

giampaolotrapasso commented 8 years ago

I will comment some rows in this PR.

As general consideration, I do not like too much the "notation" foo, bar, baz but this is your repository :-) so I stay aligned with the convention. For the records, I think that MovieChanged("The Godfather", 1972, "Francis Ford Coppola") has more meaning than MovieChanged("Foo", 0, "Bar") and you can easily confuse "bar" with "baz". For me, then, it's more simple to understand that with MovieChanged("The Godfather", 1972) you have dropper the director thanMovieChanged("Foo", 0)`. But, as said, this is a personal taste and maybe you did not see that movie (I didn't :) )