search

do-community / hacktober-board

Hacktoberfest Board
http://hacktober-board.com
6 stars 9 forks source link

[Feature] Endpoint to display labels #4

Closed Jaspaul closed 5 years ago

Jaspaul commented 5 years ago

Addresses: https://github.com/erikaheidi/hacktober-board/issues/2

This introduces a new endpoint at http://127.0.0.1:8000/l which renders all of the labels. I stole some of the styles from other parts of the site, let me know what you think.

No Hover: Screen Shot 2019-10-06 at 9 48 58 PM

Hover: Screen Shot 2019-10-06 at 9 49 04 PM

Jaspaul commented 5 years ago

I decided to add a link to the labels listing page under the issues board.

erikaheidi commented 5 years ago

Hi @Jaspaul ! Thanks a lot for your contribution. The only thing I am not sure about now is the "Labels List" link in the header. My initial plan was to add a menu to the footer including a link to this page, I think the Header is quite big and doesn't work well like a navigation thing.

Your initial commit was good enough to close the issue! Would you be so kind to revert your PR to the initial state, then I can create another issue for adding a menu to the footer.

Jaspaul commented 5 years ago

Thanks for the feedback, I'll make the suggested changes tonight.

Jaspaul commented 5 years ago

Here are the updated screens.

No Hover: Screen Shot 2019-10-07 at 11 12 52 PM

Hover: Screen Shot 2019-10-07 at 11 12 56 PM

erikaheidi commented 5 years ago

very nice, thank you @Jaspaul ! I'll be deploying the update later today. :+1: