Closed varunneal closed 1 year ago
This is awesome, great work for adding the different splitting variants and even allowing for regex!
Structure-wise, it's perfect that laypeople can just hit "Submit" (by the way, I was thinking about changing "Submit" to "Find" to stick to the aim of the project "SemanticFinder") and others can play around with the different settings.
There are only two things that I'd change style-wise:
The double arrow seems a little exotic so to say :D I'd just go with a normal one or even better, the material one:
The "Settings" word is floating around in the middle of nowhere, I guess it should find a more "stable" place, either with some button outline or it might be integrated next to the Submit-Button or even a split-button would be an option. Anyway, I'm lacking the UI phantasy too, so if someone has some good proposals they'd be more than welcome!
Logic-wise, I might have some proposals for improvement:
Not pushing for those changes though, just some ideas to discuss.
Empty strings should definitely be removed! What settings are you using to get those results? These problems may be exacerbated by Window's carriage return \r\n.
Sorry for the screenshot above, it's misleading as the settings were these:
I can reproduce the behavior on Windows Chrome and on mobile FF too. Didn't test Linux yet.
I added an advanced settings dropdown and moved the submit button up as mentioned in previous issues. While I retained @lizozom's type-checking and jsdoc changes, my added code does not yet have types.
I implemented some minor changes to correct the pesky FOUC we have been getting, including using MiniCssExtractPlugin to extract the CSS into separate files.
As always, PR live at the site: https://varunnsrivastava.github.io/SemanticFinder/
I'm finding my current implementation of the advanced settings dropdown to be a bit ugly. Any one should feel free to correct it using CSS/bootstrap magic.