do-me / SemanticFinder

SemanticFinder - frontend-only live semantic search with transformers.js
https://do-me.github.io/SemanticFinder/
MIT License
226 stars 16 forks source link

Fixed extension #37

Closed varunneal closed 1 year ago

varunneal commented 1 year ago

See here: https://github.com/do-me/SemanticFinder/pull/34#issuecomment-1694345123

Additionally, a progress bar has been added for the summary feature on the website. Demo that here: https://varunnsrivastava.github.io/SemanticFinder/

do-me commented 1 year ago

I'm just reviewing the extension and found it to be great already - thanks for your efforts. It works as expected and can be used for different tabs. I noticed that it even manages to scroll to the right section within the iframe which is quite advanced!

Some smaller bugs I found:

If it's not supported, let's maybe add a friendly notice to the users that pdfs can't be read yet and instead the web version of SemanticFinder should be used.

I'd say the latter two are minor issues so I'll go ahead, update the logo on the web version and prepare some posts.

varunneal commented 1 year ago

Thanks for reviewing! I'll review the latter couple changes.

do-me commented 1 year ago

Awesome!