Closed varunneal closed 1 year ago
The options page is great, also many thanks for adding the model selection! I think in this state it's ready to be released Chrome users.
A few unsorted thoughts:
Xenova/distiluse-base-multilingual-cased-v2
feels really buggy in the extension, for now it would probably be good advice to just use small models, maybe custom language models like kobert
for Korean etc.Cool! Let's pick a date/time we want to submit this to the chrome store. I've heard it takes about a week to get approved. In the time before the date I'll make whatever fixes I can.
In regards to this website, the scrolling is sort of working for me. One problem is that a lot of text is in the tables.
Sounds good, what do you think about submitting on Thursday, September 7?
A few questions:
Do you know whether every update needs a week for approval? If so it'd be a little annoying, but if not the first version released wouldn't matter so much and we could just as well submit it now.
When submitting to the chrome store, does it require a personal or an organization account or similar? If it's just a personal account, definitely feel free to go ahead this way, else we could also create an organization account or similar. However creating and maintaining an additional organization account seems like unnecessary overhead.
I already started to prepare some post content and another blog entry to share around but I probably need a few more days to finish up.
Sure, that works! From what I can tell, updates do require time for approval. Here is the relevant portion of the docs.
I can use a/my personal account (with a $5 fee):
There is a "group publisher" option via google groups.
I was reading through the group account section and its advantages. I think it's charming to have the option to invite other potential (future) devs so I went ahead and created the SemanticFinder Google Group we could use for this if it's ok for you (I need your Google Email to invite you).
I also wouldn't mind if you used your personal account, it's really up to you - just give me a signal what you prefer!
I went ahead and added you as owner to the google group, connected the group publisher and paid the 5$ registration fee. Not sure whether you need to pay a fee too or whether you're already covered through the group. Anyway I think we're ready. In the dashboard, we can simply upload zip-file with the extension and we're ready to go!
I just submitted the extension to the Chrome Store with the semanticfinder Google group 🎉
During the process it mentioned that it might take a while as there are plenty of (even unused?) right like activeTabs and so on. Maybe we could reconfigure something to accelerate the process?
The only thing we'd need to change is the project email address. I'll create one next week and update the settings. Maybe it would even be possible to connect it to the Google group somehow.
Google was quite fast with the review. As I kind of expected there are some permission issues we need to fix. The email states that we should remove the following permissions:
webRequest
scripting
contextMenus
Code Purpe Potassium
@VarunNSrivastava do you know where to remove (unnecessary) permissions in the extension?
This PR addresses a lot of the concerns here: https://github.com/do-me/SemanticFinder/pull/37#issuecomment-1694628473
In particular, the debounce should be fixed, the error screen is nicer, and of course an options page has been added.
The options page is very simple right now, and feel free to change it, but it should work.