do-me / SemanticFinder

SemanticFinder - frontend-only live semantic search with transformers.js
https://do-me.github.io/SemanticFinder/
MIT License
210 stars 14 forks source link

Creating an options page with a model selector #38

Closed varunneal closed 1 year ago

varunneal commented 1 year ago

This PR addresses a lot of the concerns here: https://github.com/do-me/SemanticFinder/pull/37#issuecomment-1694628473

In particular, the debounce should be fixed, the error screen is nicer, and of course an options page has been added.

The options page is very simple right now, and feel free to change it, but it should work.

do-me commented 1 year ago

The options page is great, also many thanks for adding the model selection! I think in this state it's ready to be released Chrome users.

A few unsorted thoughts:

varunneal commented 1 year ago

Cool! Let's pick a date/time we want to submit this to the chrome store. I've heard it takes about a week to get approved. In the time before the date I'll make whatever fixes I can.

In regards to this website, the scrolling is sort of working for me. One problem is that a lot of text is in the tables.

do-me commented 1 year ago

Sounds good, what do you think about submitting on Thursday, September 7?

A few questions:

varunneal commented 1 year ago

Sure, that works! From what I can tell, updates do require time for approval. Here is the relevant portion of the docs.

I can use a/my personal account (with a $5 fee):

Screen Shot 2023-09-02 at 3 33 06 PM

There is a "group publisher" option via google groups.

Screen Shot 2023-09-02 at 3 35 04 PM
do-me commented 1 year ago

I was reading through the group account section and its advantages. I think it's charming to have the option to invite other potential (future) devs so I went ahead and created the SemanticFinder Google Group we could use for this if it's ok for you (I need your Google Email to invite you).

I also wouldn't mind if you used your personal account, it's really up to you - just give me a signal what you prefer!

do-me commented 1 year ago

I went ahead and added you as owner to the google group, connected the group publisher and paid the 5$ registration fee. Not sure whether you need to pay a fee too or whether you're already covered through the group. Anyway I think we're ready. In the dashboard, we can simply upload zip-file with the extension and we're ready to go!

do-me commented 1 year ago

I just submitted the extension to the Chrome Store with the semanticfinder Google group 🎉

During the process it mentioned that it might take a while as there are plenty of (even unused?) right like activeTabs and so on. Maybe we could reconfigure something to accelerate the process?

The only thing we'd need to change is the project email address. I'll create one next week and update the settings. Maybe it would even be possible to connect it to the Google group somehow.

do-me commented 1 year ago

Google was quite fast with the review. As I kind of expected there are some permission issues we need to fix. The email states that we should remove the following permissions:

webRequest
scripting
contextMenus

Code Purpe Potassium

@VarunNSrivastava do you know where to remove (unnecessary) permissions in the extension?