search

doabit / semantic-ui-sass

Semantic UI, converted to Sass and ready to drop into Rails & Compass.
MIT License
1.15k stars 192 forks source link

Updating to the latest version of Semantic UI #101

Closed JamesChevalier closed 7 years ago

JamesChevalier commented 7 years ago

I was looking through the changelog, and the 2.2.9.0 release notes indicate:

Update Semantic UI to 2.2.9

However, the semantic-ui.js file is at version 2.1.7.

I poked around through the CSS files, and I noticed that the _site.scss file is at version 2.2.9.

So, it looks like you missed the update to that semantic-ui.js file. Would you like a pull request to bring that up to date?

doabit commented 7 years ago

@JamesChevalier Sorry for the mistake, i've updated the semantic-ui.js .

JamesChevalier commented 7 years ago

Thank you, @doabit but this has caused an error when accessing any page:

Sprockets::FileNotFound - couldn't find file 'api' with type 'application/javascript'

Based on the history of the semantic-ui.js file, I think that it's supposed to contain lines formatted like:

//= require semantic-ui/api

instead of like:

//= require api

I edited these files locally, to test, and the page loaded properly after everything followed this format. Since this worked out for me, I submitted a pull request to - hopefully - make it easier on you: https://github.com/doabit/semantic-ui-sass/pull/103