search

doabit / semantic-ui-sass

Semantic UI, converted to Sass and ready to drop into Rails & Compass.
MIT License
1.15k stars 192 forks source link

Specs don't pass #12

Closed jaredmoody closed 10 years ago

jaredmoody commented 10 years ago

When I run rspec after cloning/bundling, I get: 12 examples, 12 failures

Am I doing something wrong here or does this need to be fixed up?

doabit commented 10 years ago

On my computer, run rspec Finished in 0.0592 seconds 12 examples, 0 failures

jaredmoody commented 10 years ago

On ruby 2.1.2, all 12 specs are still failing for me, here's an example:

1) SemanticBreadcrumbsHelper semantic_breadcrumbs should return breadcrumbs
 Failure/Error: controller.instance_variable_set("@breadcrumbs", [{name: 'Home', url:'/'}])
 NameError:
   undefined local variable or method `controller' for #<RSpec::ExampleGroups::SemanticBreadcrumbsHelper::SemanticBreadcrumbs:0x007fd749fd46e8>
 # ./spec/helpers/semantic_breadcrumbs_helper_spec.rb:7:in `block (3 levels) in <top (required)>'

Full gist here: https://gist.github.com/jaredmoody/9d581c80f02f449924d9

It seems like there must be something that's causing it to succeed for you and fail for me. I'm going to fork and setup Travis CI and see what I can find.

jaredmoody commented 10 years ago

I setup Travis CI and it failed with the same errors I am seeing:

https://travis-ci.org/jaredmoody/semantic-ui-sass/builds/37723943

It seems like there's something specific to your machine that is making the tests pass.

doabit commented 10 years ago

I see, i will take a look.

jaredmoody commented 10 years ago

I found it: rspec 3 requires a new configuration option to work the same as previous versions:

config.infer_spec_type_from_file_location!

I'll send a PR.