search

doabit / semantic-ui-sass

Semantic UI, converted to Sass and ready to drop into Rails & Compass.
MIT License
1.15k stars 190 forks source link

some icons are missing #130

Closed adas172002 closed 6 years ago

adas172002 commented 6 years ago

Hi there,

It seems that upgrade to FontAwesome 5.0 broke some icons. Eg. i.icon.excel.outline, but I guess that all icons moved to far – regular style – are now missing.

At first I realised that icons from regular style are only available in Pro version of FA, but it seems that all icons that migrated from 4.7 are still here, however issue is that semantic-ui-sass does not use new font files. Currently there is just semantic-ui-sass/app/assets/fonts/semantic-ui/icons file, while free version 5.0 of font awesome is now 3 font files: regular, brands and solid Font-Awesome github.

Default style of SUI is also using them.

msmiller commented 6 years ago

I think I saw an error fly about about outline.otf or something like that being missing when trying to use an outlined icon.

doabit commented 6 years ago

Fixed #128

adas172002 commented 6 years ago

Thanks, this was pretty quick fix.