search

doabit / semantic-ui-sass

Semantic UI, converted to Sass and ready to drop into Rails & Compass.
MIT License
1.15k stars 190 forks source link

Introduce breakpoint variables #141

Closed jibiel closed 4 years ago

jibiel commented 4 years ago

Mirror breakpoint variables from Semantic UI.

Tested on a simple page with grid. Looks like the PR does what it supposed to. Ideally should be tested on the existing app utilizing the gem if possible.

doabit commented 4 years ago

Great work, any possible to auto generate this codes after run rake convert to update Semantic UI version?

jibiel commented 4 years ago

I'll look into it.

jibiel commented 4 years ago

@doabit Done. It's kinda hacky but it complies with the current rake task implementation.

One of the components is the exception though:

https://github.com/doabit/semantic-ui-sass/blob/498b8850ed8bc7436371bcb99e7be38d2e0cfe75/app/assets/stylesheets/semantic-ui/elements/_container.scss#L27-L28

https://github.com/doabit/semantic-ui-sass/blob/498b8850ed8bc7436371bcb99e7be38d2e0cfe75/app/assets/stylesheets/semantic-ui/elements/_container.scss#L45-L46

Container contains (duh) many indistinctable values which should be attended to semi-manually (similarly to the $use-custom-scrollbars case) which is simpler than to write complicated code which would basically contain almost the whole updated CSS anyway (only in Ruby).

doabit commented 4 years ago

Thanks.