search

doabit / semantic-ui-sass

Semantic UI, converted to Sass and ready to drop into Rails & Compass.
MIT License
1.15k stars 192 forks source link

invalid font-face sass syntax src: font-url('...') and font-url('...') #16

Closed markson closed 10 years ago

markson commented 10 years ago

First'y, I'm not using the Ruby build tool, but broccoli-sass which use libsass to build the sass file.

In assets/stylesheets/semantic-ui/elements/_icon.scss and In assets/stylesheets/semantic-ui/elements/_basic.icon.scss

@font-face { ... src:font-url("semantic-ui/basic.icons.eot"); src:font-url("semantic-ui/basic.icons.eot?#iefix") format('embedded-opentype'), font-url("semantic-ui/basic.icons.svg#basic.icons") format('svg'), font-url("semantic-ui/basic.icons.woff") format('woff'), font-url("semantic-ui/basic.icons.ttf") format('truetype'); ...

it's not valid syntax, I think it should be src: url('...') and url('...')'.

tested on project

netsmertia commented 10 years ago

I am using gulp with gulp-sass and wasted 2 hrs in fixing "font not loading" problem. Finally I have to change font-url to url.

mdmoore commented 10 years ago

I spent some time trying to find this error. The only reason I can see that font-url is used is that its possibly a Compass URL helper. +1 for marksons pull request.

doabit commented 10 years ago

Fixed.