doabit / semantic-ui-sass

Semantic UI, converted to Sass and ready to drop into Rails & Compass.
MIT License
1.15k stars 192 forks source link

Fonts URL not correct #24

Closed cedricfung closed 9 years ago

cedricfung commented 10 years ago

Seems the fonts URL not translated to assets pipeline in 0.19.3.0

andreslemik commented 10 years ago

in file assets/stylesheets/semantic-ui/elements/_icon.scss lines 30-42 must be:

@font-face {
  font-family: 'Icons';
  src: asset-url("semantic-ui/icons.eot");
  src: asset-url("semantic-ui/icons.eot?#iefix") format('embedded-opentype'),
    asset-url("semantic-ui/icons.svg#icons") format('svg'),
    asset-url("semantic-ui/icons.woff") format('woff'),
    asset-url("semantic-ui/icons.ttf") format('truetype');
  font-style: normal;
  font-weight: normal;
  font-variant: normal;
  text-decoration: inherit;
  text-transform: none;
}

asset-url instead url

zhulik commented 10 years ago

I have the same issue on production environment, there is no fingerprint for font assets, so browser can't find it. Any workaround?

cspeer commented 10 years ago

+1

andreslemik commented 10 years ago

use gem 'semantic-ui-sass', github: 'doabit/semantic-ui-sass' in your gemfile

doabit commented 10 years ago

I have published new version, please use gem 'semantic-ui-sass', '~> 0.19.3.1'.

cspeer commented 10 years ago

thanks a lot :+1: