search

doabit / semantic-ui-sass

Semantic UI, converted to Sass and ready to drop into Rails & Compass.
MIT License
1.15k stars 192 forks source link

Please Breakup the partials into multiple smaller partials #26

Closed mooror closed 9 years ago

mooror commented 10 years ago

Hey there, I have lately been going through your repository and have notice that your partials have to much code in them. For instance your buttons file alone has 1419 lines of code in it.I propose you break up the the scss partials into even smaller pieces like button types,groups, and states. This would certainly help out people like me who are wanting to use semantic ui, but are not willing to import a 28.4kb file that we will only use a small portion of. So here is what you could do: If you go to semantic ui's documentation you will see that each module,element,view,etc all have there own sub categories. We will look at the buttons elements for an example. Buttons have four sub sections (or categories). Types,Groups,States, and variations. Those for categories could each go in there own partial like so: File: elements/button/ _types.scss _groups.scss _states.scss _variations.scss _buttonCore.scss The last partial on the list (called bottonCore.scss) could be used to store all of the core styles that the other button partials rely on. If you can do this then I will be so thankful, you have no idea. Don't get me wrong, I'm already extremely pleased with this project. I just think that everyone would much rather only having to import styles they will actually be using. Less bloat = faster load times.

Tell me what you think, Mooror

doabit commented 9 years ago

Hi, thank you for your suggestion. i'll update the gem for Semantic UI 1.0, welcome to PR, thanks.