search

doabit / semantic-ui-sass

Semantic UI, converted to Sass and ready to drop into Rails & Compass.
MIT License
1.15k stars 192 forks source link

Grid is broken #56

Closed chrise86 closed 8 years ago

chrise86 commented 9 years ago

Using

<div class="ui two column doubling grid container">
  <div class="column">Column 1</div>
  <div class="column">Column 2</div>
</div>

The columns should obviously sit next to each other, but instead they sit underneath.

Switching to the official release works fine. It looks like it's to do with the load order. A .ui.container rule is overwriting a .ui.grid rule, forcing display: block; instead of the required display: flex;.

Propose to either include 'collections' after 'elements', or simply do not categorise them and load in the order of the official build.

doabit commented 9 years ago

If only use Semantic UI , have the same issue?

chrise86 commented 9 years ago

No that's what I mean by switching to the official release. Using the vanilla Semantic UI works fine

doabit commented 9 years ago

@chrise86 I have bump a new version. it wokrs well.

chrise86 commented 9 years ago

Ah ok cool! :+1: I did try replacing the grid file, I guess I must have needed some others too, thanks! I'll test it out before closing, just incase

jmayergit commented 8 years ago

I'm using most current version and my grids are not acting properly.

My grid is larger than my body, if I use any standard grid (e.g. ui grid container, ui grid, etc.) Alternatively if I use other types (e.g. ui internally celled grid) the grid is the correct size but then stuff like centered column, row, or grid do not actually center content.

It's very noticeable on mobile..

http://imgur.com/BVn701e

doabit commented 8 years ago

@chrise86 Do you have tried to use https://github.com/Semantic-Org/Semantic-UI, not the gem?

jmayergit commented 8 years ago

I'm assuming that was meant for me, no and I do not know how I would deploy to Heroku a rails project that required use of npm.

doabit commented 8 years ago

Can you show me your grid code?

jmayergit commented 8 years ago

http://pastebin.com/d3N4DcmM

Is it possible to use semantic-ui (not the gem) in a rails project when deploying to Heroku?

doabit commented 8 years ago

I used the gem and https://github.com/Semantic-Org/Semantic-UI/blob/master/dist/semantic.css, got same result. ebbc27a7-1033-43ed-8a8b-56d396a18d22

doabit commented 8 years ago

And the semantic-ui can work on heroku. you can reference http://semantic-ui.com/collections/grid.html

jmayergit commented 8 years ago

Alright I'm looking into it

update: okay so after going through Bower, buildpacks, etc. I stumbled upon rails-assets gem which is quite simple. A few lines of code is all that is needed and no configuration required for Heroku use. Use 'semantic' package if 'semantic-ui' gives trouble.

https://rails-assets.org/