doabit / semantic-ui-sass

Semantic UI, converted to Sass and ready to drop into Rails & Compass.
MIT License
1.15k stars 192 forks source link

Feed label does not support multiple icons #63

Closed Qqwy closed 8 years ago

Qqwy commented 8 years ago

EDIT: *Sorry for posting this here. I meant to post it on the Semantic-UI Github repo.

When having the following:

<div class="event">
  <div class="label">
    <i class="large icons">
      <i class="comment icon"></i>
      <i class="corner add icon"></i>
    </i>
  </div>
  <div class="summary">
    <div class="user">
      Username
    </div>
    added a Comment to
    <a href="/projects/2/tasks/9">Create Activities</a>
    <div class="date">
      2016-02-24 12:19:36 UTC
    </div>
  </div>

  <div class="extra text">
    <p>This is a test</p>
  </div>
</div>

the icons in the label are not shown properly.

This is caused by line 72 in views/_feed.scss, which is, by default

.ui.feed > .event > .label .icon { .... }

This matches .icon elements inside the .icons element. When changing this to something like

.ui.feed > .event > .label > .icon, .ui.feed > .event > .label > .icons { .... }

the icons display fine.