search

doadin / Baggins

zlib License
6 stars 7 forks source link

New items not showing up in Baggins right away #116

Closed StrykerJC closed 2 weeks ago

StrykerJC commented 2 weeks ago

I updated to 5.3.5 this morning and am noticing an issue where new items are not showing up in Baggins right away. Sometimes, visiting the repair vendor on my mount will trigger them to appear, sometimes that doesn't work and they just appear after several minutes. I tried visiting the bank in Valdrakken to see if maybe that triggered anything, and my game locked up when I did that.

StrykerJC commented 2 weeks ago

Upon using this version further, I'm finding that acessing the bank routinely causes the game to hang.

doadin commented 2 weeks ago

This commit ( 2d54c070ea8f428d66c65748763809a6cb4b007b ) included in v5.3.6, should address both issues, please let me know if you still have issues after updating. Thanks!

StrykerJC commented 2 weeks ago

This commit ( 2d54c07 ) included in v5.3.6, should address both issues, please let me know if you still have issues after updating. Thanks!

The game freeze issue is gone, but I'm still seeing the problem of newly looted items not showing up right away. I'm using 5.3.6.

doadin commented 2 weeks ago

This commit ( 2d54c07 ) included in v5.3.6, should address both issues, please let me know if you still have issues after updating. Thanks!

The game freeze issue is gone, but I'm still seeing the problem of newly looted items not showing up right away. I'm using 5.3.6.

items pre looting show up though yes? it is only items AFTER looting?

doadin commented 2 weeks ago

seems to be that the bags do not update when they are closed commit ( 062b38ef466f925c78e76c964a740d5e084064bf ) should fix this I pushed out a new version v5.3.7 with this fix included. Please let me know if this fixes this for you as well.

StrykerJC commented 2 weeks ago

seems to be that the bags do not update when they are closed commit ( 062b38e ) should fix this I pushed out a new version v5.3.7 with this fix included. Please let me know if this fixes this for you as well.

To your earlier question, with 5.3.6 items that had been previously looted were showing up, it was newly looted items that were not.

I've tested 5.3.9 this morning, and it seems that new items are now showing up as I loot them...but I'm noticing a new issue. The "In Use" category is not showing up. This was also the case on versions 5.3.4 and later. I can open another issue if you like, I just hadn't noticed it before. For now, I'm back to version 5.3.3, which seems to be the last version that works properly from what I've observed.

I do want to thank you for the attention on this. Baggins is a fantastic addon that really improves the default UI for WoW. I'm grateful for the work that goes into this.

doadin commented 2 weeks ago

@StrykerJC did the "In Use" category ever show? all I can find is it in the defaults it makes a "Equipment" bag with a "In Use" section that uses a "In Use" category but I don't see a "In Use" category. Even reverting back to 5.3.3.

doadin commented 2 weeks ago

@StrykerJC looks like "In Use" was renamed to "Equipment Set" in this commit ( 1a02958f399515b24f1bf7bb1448b9ed23a0675f ) a LONG time ago but the default bag setup was never adjusted for this change. Big yikes. If "In Use" was the only thing not working in 5.3.9, 5.4.0 should have all the fixes discussed here, let me know if there is any more. Sorry for this mess, appreciate you sticking with me on this, and thanks for your support!

StrykerJC commented 2 weeks ago

@StrykerJC looks like "In Use" was renamed to "Equipment Set" in this commit ( 1a02958 ) a LONG time ago but the default bag setup was never adjusted for this change. Big yikes. If "In Use" was the only thing not working in 5.3.9, 5.4.0 should have all the fixes discussed here, let me know if there is any more. Sorry for this mess, appreciate you sticking with me on this, and thanks for your support!

Sorry for the lengthy delay in responding, but I've been at work where I don't have access to WoW.

I updated to 5.4.1 when I got home, and just logged into WoW now. Initially I did not see the "In Use" category, but when I switched from Tank to DPS specs, the items appeared, so I guess that action is what triggers this in the addon. New items are also showing up immediately. My bank bags open instantly with no lagging like they were several versions ago, either.

So, it would appear that all is well on the issues I reported. I'll keep running this version tonight and see if there's anything odd that I notice, but it's looking really good so far.

Nice work, and thank you!

StrykerJC commented 2 weeks ago

@StrykerJC looks like "In Use" was renamed to "Equipment Set" in this commit ( 1a02958 ) a LONG time ago but the default bag setup was never adjusted for this change. Big yikes. If "In Use" was the only thing not working in 5.3.9, 5.4.0 should have all the fixes discussed here, let me know if there is any more. Sorry for this mess, appreciate you sticking with me on this, and thanks for your support!

Sorry for the lengthy delay in responding, but I've been at work where I don't have access to WoW.

I updated to 5.4.1 when I got home, and just logged into WoW now. Initially I did not see the "In Use" category, but when I switched from Tank to DPS specs, the items appeared, so I guess that action is what triggers this in the addon. New items are also showing up immediately. My bank bags open instantly with no lagging like they were several versions ago, either.

So, it would appear that all is well on the issues I reported. I'll keep running this version tonight and see if there's anything odd that I notice, but it's looking really good so far.

Nice work, and thank you!

Everything seems to be working normally. :) I'm closing this issue. Again, thank you for what you do.