doadin / Baggins

zlib License
6 stars 7 forks source link

[Baggins-Filtering] Fix some low hanging fruit #33

Closed toneomgomg closed 4 years ago

toneomgomg commented 4 years ago
toneomgomg commented 4 years ago

This is everything that will come from me today. :)

Are these bite-sized PR's easier to manage than the original huge one? I think I like this way of handling PR's better.

doadin commented 4 years ago

Either way works for me, I can always just cherry-pick out of a group or w.e. I always look at each commit individually anyways. So as long as each commit has its purpose or doesn't have a ton of random changes. So I guess small commits, big PR is ok. General grouping of like cleanup\re-organizing in a commit is fine even if it gets a bit large. However like reworking function would be nice to separate commits, if that makes sense. Either way though i'm not too picky.

Edit: you have done soo much already, thanks!