search

doadin / Baggins

zlib License
6 stars 7 forks source link

Compressing all or empty slots compresses everything into a single slot, hiding everything but one item per category #75

Closed Elberet closed 1 year ago

Elberet commented 1 year ago

When enabling stack compression, Baggins compresses all slots in a category into a single slot, even if they are not stacks of the same item. For example:

No compression: grafik

With "compress empty slots" enabled: grafik

This error occurrs with Baggins v4.5.0 on Wrath Classic with a German localized game client.

Molbork commented 1 year ago

Same issue with yesterday's update, did a full reset even and it's still there. Hiding other since it was huge in the uncompressed picture. image

disabling bag compression image

doadin commented 1 year ago

hmm in that one screen shot the count of the items is right. And in both theres items not shown thats weird. Are both of those wrath classic? @Elberet @Molbork

Elberet commented 1 year ago

I should probably have put this at the top of the post rather than below the screenshots, but:

This error occurrs with Baggins v4.5.0 on Wrath Classic with a German localized game client.

Molbork commented 1 year ago

hmm in that one screen shot the count of the items is right. And in both theres items not shown thats weird. Are both of those wrath classic? @Elberet @Molbork

yes, this is in wrath classic. What is weird I tried rolling back to 4.4.9 from WoWACE site and I saw the same issue. I can try an even older version later.

When I disable bag compression, I split a stack, and it showed both stacks with the same # of items. I right clicked the split stack to mail it, and it did have the right number of items in it.

image

doadin commented 1 year ago

v4.3.0 seems to be a good working version, now I just have to narrow it down to which version introduces the issue.

doadin commented 1 year ago

seems like 4.3.5 works 4.3.6+ does NOT.

doadin commented 1 year ago

Found the issue I didn't set a variable for classic versions, v4.5.2 should work.

Elberet commented 1 year ago

Can confirm, v4.5.2 fixes this issue! 😄

Elberet commented 1 year ago

Oh noes, after the recent update for WoW 3.4.1 (Baggins 4.7.9), this bug has reappeared... :(

Baggins shows this: grafik

Actual bag contents: grafik

doadin commented 1 year ago

Yea they changed the game to match with retail, so I sent out another set of changes v4.8.0 with more of the updates like I had to do to retail. Still might need more not sure.