doadin / Baggins

zlib License
6 stars 7 forks source link

[WOTLK Classic] Ulduar Patch broke Baggins #92

Closed Runkel79 closed 1 year ago

Runkel79 commented 1 year ago

With the new Ulduar patch Blizzard changed a the Addon API for Classic (According to Wowhead the changes are the same that happened with Dragonflight arrived now in Classic Wrath.)

Here are the LUA Error:

the same that happened with the Dragonflight launch in retail and are now arriving in Classic Wrath.

Here's the LUA Error Bugsack displaying:

192x Baggins/Baggins.lua:3120: attempt to call global 'GetContainerItemQuestInfo' (a nil value) [string "@Baggins/Baggins.lua"]:3120: in functionUpdateItemButton' [string "@Baggins/Baggins.lua"]:1919: in function ReallyLayoutSection' [string "@Baggins/Baggins.lua"]:760: in function?' [string "@Baggins/Baggins.lua"]:174: in function <Baggins/Baggins.lua:166>

Locals: self =

{ cannotDetachTooltip = true modules =
{ } CancelTimer = defined @Baggins/Libs/AceTimer-3.0/AceTimer-3.0.lua:147 CreateItemButton = defined @Baggins/Baggins.lua:2512 GetIncludeRule = defined @Baggins/Baggins-Filtering.lua:466 RemoveSection = defined @Baggins/Baggins.lua:3894 GetCachedItem = defined @Baggins/Baggins-Filtering.lua:538 OptimizeSectionLayout = defined @Baggins/Baggins.lua:1567 UpdateSectionContents = defined @Baggins/Baggins.lua:1198 IsAnyBankOpen = defined @Baggins/Baggins.lua:4170 RemoveRule = defined @Baggins/Baggins.lua:3911 OnTextUpdate = defined @Baggins/Baggins.lua:3634 InitOptions = defined @Baggins/Baggins-Options.lua:1081 ScheduleTimer = defined @Baggins/Libs/AceTimer-3.0/AceTimer-3.0.lua:94 UpdateDB = defined @Baggins/Baggins-Options.lua:1062 GetBagTypes = defined @Baggins/Baggins-Filtering.lua:89 UpdateItemButtons = defined @Baggins/Baggins.lua:2977 LayoutSection = defined @Baggins/Baggins.lua:1857 OnBankOpened = defined @Baggins/Baggins.lua:711 SetEnabledState = defined @Baggins/Libs/AceAddon-3.0/AceAddon-3.0.lua:420 Hook = defined @Baggins/Libs/AceHook-3.0/AceHook-3.0.lua:273 RegisterSkin = defined @Baggins/Baggins-Skins.lua:34 InitBagCategoryOptions = defined @Baggins/Baggins-Options.lua:3591 UpdateLayout = defined @Baggins/Baggins.lua:2966 CountNormalSlots = defined @Baggins/Baggins.lua:3722 AddCustomRule = defined @Baggins/Baggins-Filtering.lua:101 RuleTypeIterator = defined @Baggins/Baggins-Filtering.lua:123 NewModule = defined @Baggins/Libs/AceAddon-3.0/AceAddon-3.0.lua:231 MoveBag = defined @Baggins/Baggins.lua:3808 ForceFullRefresh = defined @Baggins/Baggins-Filtering.lua:434 DoRecheckCompress = defined @Baggins/Baggins-ItemOps.lua:230 GetAce3Opts = defined @Baggins/Baggins-Filtering.lua:152 GetName = defined @Baggins/Libs/AceAddon-3.0/AceAddon-3.0.lua:275 MoveRule = defined @Baggins/Baggins.lua:3843 defaultcategories =
{ } ClearSectionCaches = defined @Baggins/Baggins.lua:997 Disable = defined @Baggins/Libs/AceAddon-3.0/AceAddon-3.0.lua:310 CategoryMatchRemoved = defined @Baggins/Baggins.lua:869 Unhook = defined @Baggins/Libs/AceHook-3.0/AceHook-3.0.lua:417 CloseSpecialWindows = defined @Baggins/Baggins.lua:4204 CreateBagPlacementFrame = defined @Baggins/Baggins.lua:1976 IncludeItemInCategory = defined @Baggins/Baggins-Filtering.lua:498 Debug = defined @Baggins/Baggins.lua:117 CategoryMatchAdded = defined @Baggins/Baggins.lua:809 FireSignal = defined @Baggins/Baggins.lua:197 IsActive = defined @Baggins/Baggins.lua:390 CountAmmoSlots = defined @Baggins/Baggins.lua:3726 SlotMoved = defined @Baggins/Baggins.lua:908 SetDefaultModuleLibraries = defined @Baggins/Libs/AceAddon-3.0/AceAddon-3.0.lua:363 Baggins_CategoriesChanged = defined `

doadin commented 1 year ago

I have just pushed an update hopefully this solves all issues, please let me know if you run into anything else.

Runkel79 commented 1 year ago

Thank you

Runkel79 commented 1 year ago

Closed this issue by accident, i'm sorry about that.

Baggins now loads correctly, no more LUA Errors but the majority of filters are not working and the Blizzard Bank frame opens (it shouldn't)

https://i.imgur.com/yYTrtv5.jpeg

doadin commented 1 year ago

I sent out another update not sure if its 100% working but making progress. The blizzard bank opening happens on retail too, I have yet to find a fix, but that is known as well, sorry.

Runkel79 commented 1 year ago

Looking good so far i let you know if i notice any other bugs