doadin / Baggins

zlib License
6 stars 7 forks source link

Leaving coimbat lag #98

Open DreaThea opened 7 months ago

DreaThea commented 7 months ago

By using baggins I have an old issue. Always getting a lagspike whnen I leave combat. This is getting very annoying after a short time.

claytonkimber commented 7 months ago

I have the same issue. Confirmed that it was Baggins as it was the only addon that I've changed in weeks, and switching back to bagnon fixes the issue. I really don't want to use bagnon as this mod is much better at keeping my brain space uncluttered.

claytonkimber commented 7 months ago

/reload helps the issue for around 10-15 minutes, but then the issue comes back

doadin commented 6 months ago

are you guys experienceing this on retail? classic? wrath classic? SoD?

DreaThea commented 6 months ago

are you guys experienceing this on retail? classic? wrath classic? SoD?

Retail

doadin commented 6 months ago

@DreaThea you mention it being an old issue? Was there ever a version you didnt experience this lag with? I have only made changes to baggins 1 week ago and the update before that was 2 months ago. Was it ok prior to this?

doadin commented 6 months ago

@DreaThea @claytonkimber Have you tried a fresh profile? If you mkae a copy of your profile as a back up then make a new and reset it to defaults. I don't see this lag, so I can't reproduce. And with everyone being able to customize their bag layout different in so many ways it would be very hard for me to try and find out why. The way I have my profile setup is not far from default, so maybe there is a rule that is causeing this that I am not using.

Also none of you are getting any errors?

DreaThea commented 6 months ago

@DreaThea you mention it being an old issue? Was there ever a version you didnt experience this lag with? I have only made changes to baggins 1 week ago and the update before that was 2 months ago. Was it ok prior to this?

The issue is consistent in the last years. Some years ago somewhere somebody posted a change in the code, witch solved the problem iwhen I made the suggested modifications in the code. That was about 5-7 years ago. I cant find the mentioned post now.

doadin commented 6 months ago

@DreaThea I only see two changes from around 3 years ago that are releated to game freezing/stuttering and those changes are still in place. Are you using the "New" rule? Again I can not reproduce but I beleieve it is related to a certain rule that is not working right or not optimized. Trying to figure out which it is.

DreaThea commented 6 months ago

I can clear my settings, do a clean install and check if the issue appears or not as I start adding rules.

DreaThea commented 6 months ago

I made a clean install and deleted my settings. Started againg from zero and tested a few hours, made some new filters, bags etc. During this time I didnt experienced any lag when left combat. I used and tuned my settings over many years so the issue could have been caused by the old filters or overlapped categories or I just made too much filters.

doadin commented 6 months ago

@DreaThea if you could upload your old settings idk if this is too late should have maybe asked before, but if it works clean but not with old maybe something in the old was causing it and I wonder if maybe I could see any potential issues.

DreaThea commented 6 months ago

Bagginslua.txt

@DreaThea if you could upload your old settings idk if this is too late should have maybe asked before, but if it works clean but not with old maybe something in the old was causing it and I wonder if maybe I could see any potential issues.

claytonkimber commented 6 months ago

Baggins.lua.backup.zip Here are my current settings before trying a reset profile

claytonkimber commented 6 months ago

After going to a blank profile, I no longer notice the issue. Will keep testing as I add back more of the functionality that I was using

doadin commented 6 months ago

@claytonkimber this is almost perfect. if you could upload a profile that is still working it would make it sooo much easier to compair a working vs not working to find the issue.

claytonkimber commented 6 months ago

Baggins working.lua.zip

This seems to be working without the lag, granted there are nearly zero additions to that. I haven't been able to add back in all the functionality yet. Also, patch just hit, so my addons are messed up so working through that.