doadin / Plexus

Other
9 stars 2 forks source link

More global access #2

Closed Dairyman closed 4 years ago

Dairyman commented 4 years ago

Found few more.

https://github.com/doadin/Plexus/blob/4e9b19b8a3d2eb6d8659e19d90eb4fa996a1948f/Indicators/Icon.lua#L73

local  function Icon_NewIndicator(frame) 

\ https://github.com/doadin/Plexus/blob/4e9b19b8a3d2eb6d8659e19d90eb4fa996a1948f/Indicators/Icon.lua#L107

local function Icon_ClearStatus(self) 

\ https://github.com/doadin/Plexus/blob/4e9b19b8a3d2eb6d8659e19d90eb4fa996a1948f/Indicators/Icon.lua#L119

local function Icon_SetStatus(self, color, text, value, maxValue, texture, texCoords, stack, start, duration) 

\ https://github.com/doadin/Plexus/blob/4e9b19b8a3d2eb6d8659e19d90eb4fa996a1948f/Indicators/Icon.lua#L146-L147 count does not exist. Should that be value? \ \ https://github.com/doadin/Plexus/blob/4e9b19b8a3d2eb6d8659e19d90eb4fa996a1948f/Indicators/Icon.lua#L155

local function Icon_ResetIndicator(self, point, idx) 

\ https://github.com/doadin/Plexus/blob/4e9b19b8a3d2eb6d8659e19d90eb4fa996a1948f/Indicators/Icon.lua#L229

local function Icon_RegisterIndicator_Plus(id, name, point, idx) 

\ https://github.com/doadin/Plexus/blob/4e9b19b8a3d2eb6d8659e19d90eb4fa996a1948f/Indicators/Icon.lua#L240

local function Icon_RegisterIndicator(id, name, point, iconsMore1, iconsMore2) 
doadin commented 4 years ago

Believe it or not but I actually did have these in before but in development I must have changed it and forgot to add it back when I fix the issues I was having. Thanks for noticing. I believe I have corrected everything you have brought up so far. If you see any more let me know, much appreciated!