search

doadin / Plexus

Other
9 stars 2 forks source link

[Bug] Issue importing settings from grid #22

Closed Voxxel closed 3 years ago

Voxxel commented 3 years ago

Describe the bug Very bad bug on EU realms after successfully copying settings from Grid.

To Reproduce Steps to reproduce the behavior:

  1. start wow.exe
  2. Get into party with russian ppl
  3. Set your eyes on their names

Expected behavior grid

Screenshots https://i.imgur.com/DE6DYbP.jpg

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

doadin commented 3 years ago

This is due to an issue with font the default font doesn't support rus characters try one of the following fonts: 2002, AR ZhongkaiGBK Medium, MoK. ref: https://www.curseforge.com/wow/addons/plexus?comment=321 . From the game it sets a default font that is client appropriate, except when you factor people from different countries playing on different locations with different clients language settings. I am considering changing what plexus uses as default font. If I can find one that is not too crazy but also more inclusive.

Let me know if this does NOT fix your issue.

doadin commented 3 years ago

https://github.com/tomrus88/BlizzardInterfaceCode/blob/master/Interface/FrameXML/Fonts.xml STANDARD_TEXT_FONT is what plexus uses.

doadin commented 3 years ago

Did font solve your issue or no?

doadin commented 3 years ago

closing as im assuming its Duplicate: https://github.com/doadin/Plexus/issues/25#issuecomment-720117661

Voxxel commented 3 years ago

I of course know this is a font issue, but copying settings from Grid should copy the used font too. It would be better and less confusing to users, I believe.

doadin commented 3 years ago

ok reopened, fixed title. ill look into it.

doadin commented 3 years ago

fixed: fe21286005b351b2d9c18ce9c3958668aefdcdd4 ru issue still looking into settings import issue.