search

doadin / Plexus

Other
9 stars 2 forks source link

Add duration tracking option for Extra Bar #36

Closed ctdavids closed 3 years ago

ctdavids commented 3 years ago

Proposed change to support requested feature: https://www.curseforge.com/wow/addons/plexus#c497

This allows the extra bar to act as a progress bar for buffs/debuffs with durations. I've enabled it by default, but that could be changed if there is a desire to maintain existing behaviour for current users.

I've also added support for the behaviour in the test buttons (and updated a typo in their naming).

ctdavids commented 3 years ago

I can address the note about Shadowing in ExtraBar.lua from the above check in the next revision along with any other comments from the maintainers. The warning about Corner.lua however is pre-existing.

doadin commented 3 years ago

I addressed the other luacheck warning. Looks good to me, if you could just fix that one lua check warning Indicators/ExtraBar.lua:64. Id be happy to merge.

ctdavids commented 3 years ago

Rebased against your change and update the self-nomenclature. Checks seem to have been successful.