search

doakey3 / Subsimport

Blender 3d addon for importing and editing subtitle and lyric files.
GNU General Public License v3.0
61 stars 15 forks source link

overlapping clips #12

Closed GodsITguy closed 2 years ago

GodsITguy commented 2 years ago

When I import the .srt file that I'm creating with pytranscriber, it get overlapping text clips. When I select the whole channel and move down the timeline, all overlapping clips snap to other available channels. I'm not getting an error, but I remember reading your instructions. My source SRT files don't show overlapping times in the source file I exported the SRT from Blender and it shows overlapping in miliseconds.

"It is recommended that if you're making lyrics for songs that you increase the scene FPS to 100 or even 1000 frames per second before importing. The reason is that .srt files support time data down to the millisecond, but strips must conform to the scene's FPS value. If a low FPS is used, then the minimum timing difference will be limited by the scene FPS." "Subimport does not allow any subtitles to overlap times and will automatically remove overlaps on import."

I changed the frame rate to 120 and it still does it plus it's not deleting the overlapping clips (good thing) as the instructions note.

Also, I noticed your version didn't change, but your source files did. Could you be so kind and post instructions on how to integrate these updates. I just downloaded the master code and the zip from downloads and imported them both as separate add-on's Not sure if that was correct.

yue-dongchen commented 2 years ago

Seems to have been broken by a56464b. The start and end times in seconds should not be converted to integers before rounding. I will test it when I get to it.

yue-dongchen commented 2 years ago

Alright, that solves the issue. I will submit a pull request tomorrow.

GodsITguy commented 2 years ago

Thanks Yue. I'll wait to see the update posted to the repository.