search

dobarkod / cookie-banner

JavaScript based cookie-info banner for complying with EU cookie law
MIT License
425 stars 85 forks source link

Custom close icon #10

Closed chorijan closed 10 years ago

chorijan commented 10 years ago

Are you planning to add a possibility to change the default close icon (I see the icon is currently hardcoded)?

zytzagoo commented 10 years ago

Should be easily doable now using latest master

senko commented 10 years ago

Fix published on cookiebanner.eu.

chorijan commented 10 years ago

Doesn't work properly when I insert a html tag for a chosen icon font (example: <i class="fa fa-times"></i>). It brakes the layout of the cookie bar.

senko commented 10 years ago

@chorijan what happens exactly? the HTML is quoted?

zytzagoo commented 10 years ago

It's breaking on double quotes probably, try using data-close-text="<i class='fa fa-times'></i>"?

chorijan commented 10 years ago

@senko @zytzagoo yep it was breaking on double quotes. with the single quotes its working. thx :+1: