search

dobarkod / cookie-banner

JavaScript based cookie-info banner for complying with EU cookie law
MIT License
425 stars 85 forks source link

Travis #12

Closed senko closed 10 years ago

senko commented 10 years ago

Support for running automated tests via Travis CI

senko commented 10 years ago

Hey @zytzagoo I tried to set up phantomjs on Travis to automatically run the test suite. It seems that two of the tests fail under phantom (it happens on my local machine, on Travis, with the test runner in this pull request and with a custom (simpler/no output) one), while they run just fine in Chrome and Firefox.

No idea why that should happen - the best I can assume is that for some reason the script doesn't set up window.Cookiebanner.

Care to take a look?

zytzagoo commented 10 years ago

Ton of work atm. I'll try taking a look if/when I get a chance this week, end of weekend at the latest.

senko commented 10 years ago

No worries, cheers mate.

zytzagoo commented 10 years ago

Squeezed it in :) "Works for me" after merging #13