search

dobarkod / cookie-banner

JavaScript based cookie-info banner for complying with EU cookie law
MIT License
425 stars 85 forks source link

Add option to dismiss banner on click (anywhere on the page) #35

Closed camilledalmeras closed 8 years ago

camilledalmeras commented 8 years ago

The accept-on-scroll feature is lovely, this one might complement it usefully.

senko commented 8 years ago

Looks good to me. @zytzagoo want to chime in?

Btw as I'm pretty much inactive on the project, @zytzagoo would you be interested in taking over the maintenance of the project?

zytzagoo commented 8 years ago

@senko having some tests covering the new option would be great, but since there were other options/features already merged without tests I guess it's not a blocker.

re: maintenance, sure, I'll help out while I can (my 5mo son might make it hard to always find the time) :)

senko commented 8 years ago

Sounds good :)

senko commented 8 years ago

@camilledalmeras thanks for the patch!

camilledalmeras commented 8 years ago

@senko You're very much welcome, I am the one who is grateful for all your and others' good work on cookie-banner

@zytzagoo re: 5mo babies: that sounds all too familiar... Stay strong! ;)