search

dobarkod / cookie-banner

JavaScript based cookie-info banner for complying with EU cookie law
MIT License
425 stars 85 forks source link

Could you help add git tag #41

Closed kennynaoh closed 7 years ago

kennynaoh commented 7 years ago

Hello @zytzagoo I am the member of cdnjs project. We want to host this library. Git tag can help us to know your release version, and we can auto-update the version when you have new release. Could you please help us add git tag. Thanks for your help!

https://github.com/cdnjs/cdnjs/issues/9956

zytzagoo commented 7 years ago

Hi @kennynaoh , I think I don't have commit/push access here, so can't really do much about it. Ping @senko.

senko commented 7 years ago

@kennynaoh awesome, would be great to be hosted on cdnjs!

I’ll be happy to tag the latest release; please let me know if there are any other things we could or should to to be a better cdnjs citizen.

@zytzagoo let me know if you’d want / accept edit/admin privs for the repo, you’re more active here than I am, so if you volounteer to shoulder the burden of (co)maintaining this officially, lemme know :-)

zytzagoo commented 7 years ago

@senko i'll help as much as I can, sure. I think I said as much already (yep, found it: https://github.com/dobarkod/cookie-banner/pull/35#issuecomment-162850521)

senko commented 7 years ago

@zytzagoo Sheesh I’m blind :-) Great, invited you as admin!

kennynaoh commented 7 years ago

Good to listen that. Please let me know if there is any update. Thanks @zytzagoo @senko

zytzagoo commented 7 years ago

@kennynaoh tag/release added. Minified js is not included in it though, is that ok?

BTW, does anyone know if github's "include binaries" thingy (when doing a release through github ui) allows treating .min.js as "binaries" and if the file can be placed in arbitrary location within the zip/tarball?

(don't have the minified version handy [and/or dev env] on this puter, so can't check myself until tomorrow)

senko commented 7 years ago

Looking at https://help.github.com/articles/creating-releases/ it doesn’t look as if it gives a lot of leeway with binaries upload

zytzagoo commented 7 years ago

Indeed. Might not matter much anyway: https://webdevlaw.uk/2017/01/10/cookie-law-reform-announcement/

kennynaoh commented 7 years ago

@zytzagoo It's fine not to add minified file. I can help minify it. Thanks! I will add this ASAP.

kennynaoh commented 7 years ago

It's already on CDNJS https://cdnjs.com/libraries/cookie-banner. Thank guys!