Infrastructure tweaks - Githubissues

dobarkod / cookie-banner

JavaScript based cookie-info banner for complying with EU cookie law

MIT License

425 stars 85 forks source link

Infrastructure tweaks #42

Closed zytzagoo closed 7 years ago

zytzagoo commented 7 years ago

add mini license header to the top of built min.js file (pulling data from package.json)
add LICENSE.md file (should we just link to it from README.md now or something?)
added devDependencies (and other stuff) to package.json + verified current suite passes with specified versions
Upgrade qunit tests runner to avoid ReferenceError: Can't find variable: QUnit (happened when running make test on newer phantomjs version)

senko commented 7 years ago

looks good to me!

zytzagoo commented 7 years ago

Yeah, just not entirely sure about that 1.0.0 version thing, although I really think we can safely consider it stable.

Gonna see if there are some other changes needed for cdnjs thingy in https://github.com/dobarkod/cookie-banner/issues/41 before merging this if that's ok...

senko commented 7 years ago

Yeah I think it can be considered pretty stable, esp. because we don’t want to break compat due to people already hotlinking from cookiebanner.eu.

Re other potential changes — sure, also would be great if you could have a look at #39 and see if that (and accompanying #40) can be merged, I think they’re ok but second pair of eyes never hurts :)