search

dobarkod / cookie-banner

JavaScript based cookie-info banner for complying with EU cookie law
MIT License
425 stars 85 forks source link

Adding debug mode #62

Closed akmur closed 6 years ago

akmur commented 6 years ago

I noticed debug mode is not working, although there was a "TODO" on a test mode. I have added a line to make debug work, and removed the TODO on the test mode. Also, I've updated the readme file. Not sure if this is what you intended to do, hope this helps anyway

zytzagoo commented 6 years ago

Hello and thanks a lot for the contribution!

I still see this.test_mode in there (still unused), let's remove that completely? (since a comment says "removed unused test_mode", but I don't see that it's actually removed?)

Could you also add a test that proves the debug option is doing what it's supposed to be doing?

Ideally, you'd also squash the above commits into a single commit/change and then force push the changes in order to make it slightly easier to review / merge and keep the history clean.

zytzagoo commented 6 years ago

Looks good to me, thanks! If @senko doesn't see any issues, we'll deal with the changelog etc. afterwards...