search

dobarkod / cookie-banner

JavaScript based cookie-info banner for complying with EU cookie law
MIT License
425 stars 85 forks source link

Callbacks not working on dist/cookiebanner.min.js #77

Closed zeeshangulzar closed 6 years ago

zeeshangulzar commented 6 years ago

Callbacks e.g. onInserted not seems to be working on minified Js file. But working fine on source(js) file. Kindly check.

zytzagoo commented 6 years ago

Thanks, that’s (somewhat) expected for now, minified file is from 1.2.2 and hasn’t been re-minified since... Will create latest master minified version later today.

May I ask how you found this out? Were you using it via some cdn pointing to master version or just downloaded master zip from github? Were the callbacks something specific that you wanted as a feature and that’s why you went with master version and not an existing release?

zeeshangulzar commented 6 years ago

Yep, I just grab the latest zip from github. And testing callbacks and found out the issue. (Also onInserted works as expected but onClosed not calling somehow. ) By the way, thanks for looking into the Js minified issue.

zytzagoo commented 6 years ago

Minified version updated.

Can you share a bit more details about onClosed not working? There's a basic test in tests.js L:251 that confirms it's being called as expected in that case at least...

zytzagoo commented 6 years ago

Closing, please reopen or create a new issue if something is not right.