search

dobladov / youtube2Anki

Convert Youtube Transcripts to Anki cards
https://chrome.google.com/webstore/detail/youtube2anki/boebbbjmbikafafhoelhdjeocceddngi
GNU General Public License v3.0
88 stars 11 forks source link

Title Header Causing Issues #12

Closed Oafish1 closed 3 years ago

Oafish1 commented 3 years ago

Hello! Thank you for making this.

Neither of the addons (Firefox/Chrome) work for me out of the box. This seemed to be because title was being returned as null since document.querySelector("h1").firstChild.innerText finds nothing.

However, a slight modification to document.querySelector("h1.title").firstChild.innerText on lines 46 and 71 of youtube2Anki.js from version 0a75e (two pulls ago) fixed everything for me.

This version also needed the first line of popup.js to be changed from const connectionMessage = document.getElementById("connectionMessages") to const connectionMessage = document.getElementById("connectionMessage") which you already addressed in later versions.

dobladov commented 3 years ago

Thanks for reporting it, I'm working on a new version of the add-on that will fix this issue and bring new functionality hopefully I will create a new release by the end of the week

Oafish1 commented 3 years ago

Awesome! Looking forward to it. Loving the addon.

dobladov commented 3 years ago

I already submitted the changes for Chrome, it should be updated after it passes the review process. Unfortunately Firefox does not support manifest v3 yet, so I might create a patch version instead of a new release for this browser.

dobladov commented 3 years ago

Submitted now a fixed version with Firefox, unfortunately it will not have the new functionality just bug fixes.

dobladov commented 3 years ago

The new Chrome version is now published.