search

dobladov / youtube2Anki

Convert Youtube Transcripts to Anki cards
https://chrome.google.com/webstore/detail/youtube2anki/boebbbjmbikafafhoelhdjeocceddngi
GNU General Public License v3.0
88 stars 11 forks source link

Didn't find star buttons #2

Closed LeeLizuoLiu closed 5 years ago

LeeLizuoLiu commented 5 years ago

Hi, thanks for your great add-ons, I did't find the star button. I've tried both chrome and firefox. Here are screenshots. image

Above is chrome, Below is firefox. image image

The chrome version is Version 75.0.3770.100 (Official Build) (64-bit) The firefox version is 67.0.4 (64-bit)

Really thanks for your help!

dobladov commented 5 years ago

Try to reload the link to the video (https://www.youtube.com/watch?*) instead of navigating to the video from another page, is a little bit tricky how to attach the star button, if it keeps not working for you, I will try to find an alternative way to do it.

LeeLizuoLiu commented 5 years ago

No, reloading the link still doesn't work for me.

dobladov commented 5 years ago

In that case, try to see if there is any error on your console that might help me to find the problem, press F12 to show it.

I'm planing to do a lot of refactoring of the code given the feedback of some user, so in the future might work for you too.

dobladov commented 5 years ago

I made a complete refactor for how the subtitles are generated, now the star icon is not required, please, give it another try, I hope now it works for you.

example

LeeLizuoLiu commented 5 years ago

Thanks, I updated and tried the new way, it still doesn't work for me. Below is the error reported.

image image

LeeLizuoLiu commented 5 years ago

I opened the transcript before I clicked the icons. image

LeeLizuoLiu commented 5 years ago

I found the bug. image

Here, I deleted ytd-engagement-panel-section-list-renderer #body, then it worked.

image

I didn't find ytd-engagement-panel-section-list-renderer in elements. Could this be the system issue? For different system, youtube may use different html. Thank you for your great add-on!

dobladov commented 5 years ago

I should apply your solution, I was using ytd-engagement-panel-section-list-renderer as the way to attach the star, but I also had problems in the past since they kept changing the name of this tag.

I'm glad to see is working for you now, thanks for the feedback.

dobladov commented 5 years ago

I shipped your solution with version 0.0.7, thanks again!