dobromir-hristov / vue-vimeo-player

Vue.js wrapper for Vimeo player
MIT License
111 stars 56 forks source link

player value isn't exposed to parent #104

Open iangoodall opened 3 months ago

iangoodall commented 3 months ago

I was looking into this issue https://github.com/dobromir-hristov/vue-vimeo-player/issues/103 by creating a fork of the player and realised that the player as a ref is undefined. Here's a screenshot of Vue Dev Utilities showing the component:

image

So when you try to call setCurrentTime on the player instance it isn't defined. I tried changing the player to a reactive property but that created its own issues.

One thing I tried was to add a setCurrentTime() function in the vue-vimeo-player which you can see in my screenshot. That works, but would mean that I would need to add a function to correspond to every function that the Vimeo player provides, which seems a bit redundant.

Wondering if anyone has any ideas how we can make sure the player is exposed to the parent component so we can use the other Vimeo player APIs.

I know this was raised a while ago and PR was done for it https://github.com/dobromir-hristov/vue-vimeo-player/issues/85 but below the closing of that issue those who were affected ended up creating a workaround.