search

dobromir-hristov / vue-vimeo-player

Vue.js wrapper for Vimeo player
MIT License
111 stars 56 forks source link

Controls prop #57

Closed kovaletsyurii closed 3 years ago

kovaletsyurii commented 3 years ago

Does it possible to make controls prop reactive?

eduardoliron commented 3 years ago

If you are using Vue as your framewor, you should simply bind the controls option to a boolean variable

:controls="myControlsBooleanVar"

kovaletsyurii commented 3 years ago

@eduardoliron Yes I do this, but it doesn't work for me, I will try to create a reproduce repo

kovaletsyurii commented 3 years ago

@eduardoliron I use it like vimeo-player( ref="player" :video-id="videoID" :player-height="null" :controls="showVideoControls" @playing="onPlay" @play="onPlay" @pause="onPause" @ended="onEnded" )

and in my code I set this.showVideoControls = true, but player controls panel still not visible.

eduardoliron commented 3 years ago

You are right. I could reproduce the error.

kovaletsyurii commented 3 years ago

@eduardoliron Do you know a way to solve it? I've tried a few older versions of this library and I've reproduce this issue for all versions that I've tried.

dobromir-hristov commented 3 years ago

Should be fixed with vue-vimeo-player@1.0.4 (0c21bad519f7056c1e8d23cdead2746e252520dc)